Fix the selected background in Toolbar on Windows#3202
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Fix the selected background in Toolbar on Windows#3202vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Author
See ticket for more screenshots |
Contributor
Test Results (win32) 28 files 28 suites 4m 46s ⏱️ Results for commit 0479587. ♻️ This comment has been updated with latest results. |
Take the same approach as Button.java, manually fill the background for checked items and tell Windows to skip its own background: Now in dark mode, for each toolbar item: - Checked: fill with getDifferentColor() (20% lighter shade) - Hot (hovered): fill with getSlightlyDifferentColor() (10% lighter shade) - Normal: fill with the background color Then TBCDRF_NOBACKGROUND prevents Windows from painting its own white highlight on top. Fixes: eclipse-platform#217
vogella
force-pushed
the
fix/toolbar-background-win
branch
from
0c4acae to
0479587
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the same approach as Button.java, manually fill the background for checked items and tell Windows to skip its own background:
Now in dark mode, for each toolbar item:
Then TBCDRF_NOBACKGROUND prevents Windows from painting its own white highlight on top.
Fixes: #217